Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect number order when sorting assets by title #12030

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

somebody1234
Copy link
Contributor

Pull Request Description

  • Respect number order when sorting assets by title
    • New Project 1 < New Project 2 < New Project 10 rather than lexicographic sort (1 < 10 < 2)
  • Use user's locale when sorting names

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Jan 10, 2025
@mergify mergify bot merged commit b02e228 into develop Jan 10, 2025
40 of 42 checks passed
@mergify mergify bot deleted the wip/sb/dictionary-sort-for-assets branch January 10, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants